Remove getNonNullableType application in checkIdentifier #60523

bgenia · 2024-11-17T12:12:13Z

Andarist · 2024-11-17T13:26:47Z

Out of pure curiosity - do you know why this doesn't regress the tests introduced by #50092 ? :p

jakebailey · 2024-11-17T16:09:25Z

That PR's test didn't seem to enable strict mode...

bgenia · 2024-11-18T01:44:54Z

Enabling strict mode in that test causes undefined to appear in the baselines, but everything still seems correct. I also tried applying these changes directly to that PR to ensure that other PRs didn't affect it, and the result is the same, both with and without strict null checks. I guess this wasn't needed? At least for that test.

jakebailey · 2025-06-30T23:20:00Z

@typescript-bot test it

typescript-bot · 2025-06-30T23:20:05Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-07-01T00:19:52Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-07-01T00:27:52Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60523/merge:

Something interesting changed - please have a look.

Details

puppeteer

test/tsconfig.json

[NEW] error TS7034: Variable 'testResponse' implicitly has type 'any' in some locations where its type cannot be determined.
- test/src/oopif.spec.ts#L647 in test/tsconfig.json
- test/src/worker.spec.ts#L157 in test/tsconfig.json
[NEW] error TS7005: Variable 'testResponse' implicitly has an 'any' type.
- test/src/oopif.spec.ts#L668 in test/tsconfig.json
- test/src/worker.spec.ts#L175 in test/tsconfig.json

typescript-bot · 2025-07-01T00:38:18Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,370	_62,370	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,386	_50,386	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{196,006k (± 0.73%)}	_{196,571k (± 0.08%)}	_~	_196,291k	_196,740k	_{p=0.689 n=6}
_{Parse Time}	_{1.61s (± 1.14%)}	_{1.59s (± 1.56%)}	_~	_1.54s	_1.61s	_{p=0.140 n=6}
_{Bind Time}	_{0.88s (± 1.95%)}	_{0.88s (± 1.38%)}	_~	_0.87s	_0.90s	_{p=0.796 n=6}
_{Check Time}	_{11.75s (± 0.53%)}	_{11.75s (± 0.50%)}	_~	_11.67s	_11.83s	_{p=0.936 n=6}
_{Emit Time}	_{3.28s (± 1.89%)}	_{3.33s (± 2.53%)}	_~	_3.25s	_3.49s	_{p=0.377 n=6}
_{Total Time}	_{17.53s (± 0.46%)}	_{17.54s (± 0.42%)}	_~	_17.46s	_17.65s	_{p=0.872 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅₆	₅₈	_{+2 (+ 3.57%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_948,753	_948,753	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,846	_410,846	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,193k (± 0.00%)}	_{1,225,264k (± 0.01%)}	_~	_1,225,161k	_1,225,375k	_{p=0.173 n=6}
_{Parse Time}	_{7.98s (± 0.53%)}	_{7.92s (± 0.43%)}	_{-0.06s (- 0.71%)}	_7.86s	_7.95s	_{p=0.029 n=6}
_{Bind Time}	_{2.29s (± 0.93%)}	_{2.29s (± 0.36%)}	_~	_2.28s	_2.30s	_{p=0.463 n=6}
_{Check Time}	_{38.05s (± 0.39%)}	_{37.92s (± 0.42%)}	_~	_37.69s	_38.12s	_{p=0.335 n=6}
_{Emit Time}	_{17.85s (± 0.40%)}	_{17.88s (± 0.42%)}	_~	_17.79s	_17.97s	_{p=0.471 n=6}
_{Total Time}	_{66.17s (± 0.23%)}	_{66.01s (± 0.23%)}	_~	_65.72s	_66.14s	_{p=0.126 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,509,183	_2,509,183	_~	_~	_~	_{p=1.000 n=6}
_Types	_892,716	_892,716	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,804,455k (± 0.00%)}	_{2,804,457k (± 0.00%)}	_~	_2,804,327k	_2,804,564k	_{p=0.936 n=6}
_{Parse Time}	_{10.51s (± 0.47%)}	_{10.51s (± 0.20%)}	_~	_10.48s	_10.53s	_{p=0.872 n=6}
_{Bind Time}	_{2.76s (± 0.58%)}	_{2.76s (± 0.62%)}	_~	_2.74s	_2.78s	_{p=0.742 n=6}
_{Check Time}	_{100.89s (± 0.27%)}	_{102.89s (± 2.10%)}	_{+2.00s (+ 1.98%)}	_100.96s	_106.41s	_{p=0.031 n=6}
_{Emit Time}	_{0.37s (± 3.14%)}	_{0.37s (± 2.04%)}	_~	_0.36s	_0.38s	_{p=0.396 n=6}
_{Total Time}	_{114.53s (± 0.25%)}	_{116.53s (± 1.86%)}	_{+1.99s (+ 1.74%)}	_114.58s	_120.08s	_{p=0.045 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,081	_1,227,081	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,474	_267,474	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,852,957k (±13.20%)}	_{2,730,884k (±14.68%)}	_~	_2,363,900k	_3,097,656k	_{p=1.000 n=6}
_{Parse Time}	_{6.65s (± 0.80%)}	_{6.63s (± 1.77%)}	_~	_6.48s	_6.77s	_{p=0.873 n=6}
_{Bind Time}	_{2.17s (± 1.32%)}	_{2.15s (± 1.25%)}	_~	_2.12s	_2.18s	_{p=0.374 n=6}
_{Check Time}	_{42.77s (± 0.44%)}	_{42.90s (± 0.76%)}	_~	_42.65s	_43.51s	_{p=0.575 n=6}
_{Emit Time}	_{3.44s (± 2.11%)}	_{3.49s (± 6.00%)}	_~	_3.30s	_3.82s	_{p=0.873 n=6}
_{Total Time}	_{55.05s (± 0.54%)}	_{55.20s (± 0.69%)}	_~	_54.80s	_55.89s	_{p=0.810 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,227,081	_1,227,081	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,474	_267,474	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,040,576k (± 9.78%)}	_{2,918,960k (±12.85%)}	_~	_2,433,610k	_3,162,506k	_{p=0.378 n=6}
_{Parse Time}	_{6.92s (± 1.21%)}	_{6.86s (± 1.88%)}	_~	_6.71s	_7.04s	_{p=0.298 n=6}
_{Bind Time}	_{2.17s (± 2.41%)}	_{2.20s (± 1.88%)}	_~	_2.14s	_2.24s	_{p=0.377 n=6}
_{Check Time}	_{42.93s (± 0.41%)}	_{42.84s (± 0.33%)}	_~	_42.60s	_42.96s	_{p=0.689 n=6}
_{Emit Time}	_{3.54s (± 1.42%)}	_{3.52s (± 1.88%)}	_~	_3.43s	_3.59s	_{p=0.688 n=6}
_{Total Time}	_{55.57s (± 0.29%)}	_{55.43s (± 0.47%)}	_~	_55.07s	_55.69s	_{p=0.689 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,548	_262,548	_~	_~	_~	_{p=1.000 n=6}
_Types	_107,156	_107,156	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,874k (± 0.01%)}	_{441,874k (± 0.01%)}	_~	_441,783k	_441,949k	_{p=0.936 n=6}
_{Parse Time}	_{3.53s (± 1.01%)}	_{3.54s (± 1.57%)}	_~	_3.47s	_3.61s	_{p=1.000 n=6}
_{Bind Time}	_{1.32s (± 1.07%)}	_{1.31s (± 0.79%)}	_~	_1.30s	_1.33s	_{p=0.410 n=6}
_{Check Time}	_{18.87s (± 0.17%)}	_{18.85s (± 0.21%)}	_~	_18.81s	_18.91s	_{p=0.376 n=6}
_{Emit Time}	_{1.53s (± 1.53%)}	_{1.54s (± 1.16%)}	_~	_1.52s	_1.56s	_{p=0.452 n=6}
_{Total Time}	_{25.25s (± 0.17%)}	_{25.24s (± 0.17%)}	_~	_25.16s	_25.29s	_{p=0.574 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₁	₇₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,367	_225,367	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,290	_94,290	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,185k (± 0.03%)}	_{371,189k (± 0.05%)}	_~	_371,056k	_371,552k	_{p=0.810 n=6}
_{Parse Time}	_{3.60s (± 0.74%)}	_{3.59s (± 0.84%)}	_~	_3.56s	_3.63s	_{p=0.871 n=6}
_{Bind Time}	_{1.97s (± 0.95%)}	_{1.96s (± 1.42%)}	_~	_1.93s	_2.01s	_{p=0.196 n=6}
_{Check Time}	_{20.33s (± 0.28%)}	_{20.28s (± 0.27%)}	_~	_20.19s	_20.36s	_{p=0.257 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{25.91s (± 0.31%)}	_{25.83s (± 0.27%)}	_~	_25.71s	_25.91s	_{p=0.172 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃₃	₃₃	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,499,319	_3,499,319	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,177,227	_1,177,227	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,549,840k (± 0.00%)}	_{3,549,778k (± 0.01%)}	_~	_3,549,488k	_3,550,289k	_{p=0.471 n=6}
_{Parse Time}	_{14.94s (± 0.41%)}	_{14.95s (± 0.49%)}	_~	_14.87s	_15.06s	_{p=0.872 n=6}
_{Bind Time}	_{4.86s (± 0.18%)}	_{4.85s (± 0.45%)}	_~	_4.81s	_4.87s	_{p=0.284 n=6}
_{Check Time}	_{95.25s (± 2.90%)}	_{95.08s (± 3.45%)}	_~	_92.94s	_101.03s	_{p=0.471 n=6}
_{Emit Time}	_{30.34s (± 5.58%)}	_{31.38s (± 8.14%)}	_~	_29.21s	_35.64s	_{p=0.689 n=6}
_{Total Time}	_{145.38s (± 2.28%)}	_{146.26s (± 3.68%)}	_~	_141.93s	_153.70s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_318,019	_318,019	_~	_~	_~	_{p=1.000 n=6}
_Types	_137,705	_137,705	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{472,209k (± 0.01%)}	_{472,203k (± 0.04%)}	_~	_472,007k	_472,511k	_{p=0.810 n=6}
_{Parse Time}	_{4.37s (± 0.51%)}	_{4.36s (± 1.00%)}	_~	_4.31s	_4.42s	_{p=0.627 n=6}
_{Bind Time}	_{1.78s (± 1.89%)}	_{1.77s (± 0.85%)}	_~	_1.75s	_1.79s	_{p=0.935 n=6}
_{Check Time}	_{20.72s (± 0.53%)}	_{20.70s (± 0.51%)}	_~	_20.55s	_20.85s	_{p=0.810 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{26.87s (± 0.28%)}	_{26.83s (± 0.52%)}	_~	_26.67s	_27.04s	_{p=0.470 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_665,978	_665,978	_~	_~	_~	_{p=1.000 n=6}
_Types	_199,345	_199,345	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{570,365k (± 0.01%)}	_{570,173k (± 0.04%)}	_~	_569,951k	_570,390k	_{p=0.093 n=6}
_{Parse Time}	_{5.29s (± 0.50%)}	_{5.29s (± 0.44%)}	_~	_5.25s	_5.31s	_{p=1.000 n=6}
_{Bind Time}	_{1.64s (± 0.94%)}	_{1.66s (± 1.64%)}	_~	_1.63s	_1.70s	_{p=0.167 n=6}
_{Check Time}	_{24.58s (± 0.24%)}	_{24.53s (± 0.28%)}	_~	_24.46s	_24.64s	_{p=0.261 n=6}
_{Emit Time}	_0.00s	_{0.01s (±154.76%)}	_~	_0.00s	_0.02s	_{p=0.174 n=6}
_{Total Time}	_{31.52s (± 0.17%)}	_{31.50s (± 0.27%)}	_~	_31.42s	_31.64s	_{p=0.688 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-07-01T01:49:43Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60523/merge:

Something interesting changed - please have a look.

Details

ether/etherpad-lite

src/tsconfig.json

error TS7034: Variable 'agentResolve' implicitly has type 'any' in some locations where its type cannot be determined.
- src/tests/backend/common.ts#L69
error TS7005: Variable 'agentResolve' implicitly has an 'any' type.
- src/tests/backend/common.ts#L102
error TS7034: Variable 'cancelTimeout' implicitly has type 'any' in some locations where its type cannot be determined.
- src/tests/backend/common.ts#L123
error TS7005: Variable 'cancelTimeout' implicitly has an 'any' type.
- src/tests/backend/common.ts#L156
error TS7034: Variable 'tempListener' implicitly has type 'any' in some locations where its type cannot be determined.
- src/tests/backend/specs/hooks.ts#L807
error TS7005: Variable 'tempListener' implicitly has an 'any' type.
- src/tests/backend/specs/hooks.ts#L817
- src/tests/backend/specs/hooks.ts#L830

facebook/lexical

5 of 16 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS7034: Variable 'editor' implicitly has type 'any' in some locations where its type cannot be determined.
- packages/lexical-react/src/__tests__/unit/PlainRichTextPlugin.test.tsx#L67
- packages/lexical-react/src/__tests__/unit/PlainRichTextPlugin.test.tsx#L121
error TS7005: Variable 'editor' implicitly has an 'any' type.
error TS7034: Variable 'anchorElementRef' implicitly has type 'any' in some locations where its type cannot be determined.
- packages/lexical-react/src/__tests__/unit/useMenuAnchorRef.test.tsx#L38
error TS7005: Variable 'anchorElementRef' implicitly has an 'any' type.
- packages/lexical-react/src/__tests__/unit/useMenuAnchorRef.test.tsx#L62

langchain-ai/langchainjs

87 of 95 projects failed to build with the old tsc and were ignored

langchain-core/tsconfig.json

error TS7034: Variable 'tappedPromiseResolver' implicitly has type 'any' in some locations where its type cannot be determined.
- langchain-core/src/tracers/event_stream.ts#L263
error TS7005: Variable 'tappedPromiseResolver' implicitly has an 'any' type.
- langchain-core/src/tracers/event_stream.ts#L304

langchain-core/tsconfig.cjs.json

error TS7034: Variable 'tappedPromiseResolver' implicitly has type 'any' in some locations where its type cannot be determined.
- langchain-core/src/tracers/event_stream.ts#L263
error TS7005: Variable 'tappedPromiseResolver' implicitly has an 'any' type.
- langchain-core/src/tracers/event_stream.ts#L304

Andarist · 2025-07-01T11:38:05Z

This feels like something that shouldn't be required in strict mode without reporting an error or the need to add an assertion or smth: TS playground. This puppeteer break looks like an improvement to me

All other breaks reported above look basically the same to me. They assign to an unannotated variable from within a callback and then access that auto-typed variable with a non-null assertion.

Remove getNonNullableType application in checkIdentifier

46cd421

typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Nov 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove getNonNullableType application in checkIdentifier #60523

Remove getNonNullableType application in checkIdentifier #60523

bgenia commented Nov 17, 2024

Uh oh!

Andarist commented Nov 17, 2024

Uh oh!

jakebailey commented Nov 17, 2024

Uh oh!

bgenia commented Nov 18, 2024

Uh oh!

jakebailey commented Jun 30, 2025

Uh oh!

typescript-bot commented Jun 30, 2025 •

edited

Loading

Uh oh!

typescript-bot commented Jul 1, 2025

Uh oh!

typescript-bot commented Jul 1, 2025

puppeteer

test/tsconfig.json

Uh oh!

typescript-bot commented Jul 1, 2025

tsc

Uh oh!

typescript-bot commented Jul 1, 2025

ether/etherpad-lite

src/tsconfig.json

facebook/lexical

tsconfig.json

langchain-ai/langchainjs

langchain-core/tsconfig.json

langchain-core/tsconfig.cjs.json

Uh oh!

Andarist commented Jul 1, 2025

Uh oh!

Uh oh!

Remove getNonNullableType application in checkIdentifier #60523

Are you sure you want to change the base?

Remove getNonNullableType application in checkIdentifier #60523

Conversation

bgenia commented Nov 17, 2024

Uh oh!

Andarist commented Nov 17, 2024

Uh oh!

jakebailey commented Nov 17, 2024

Uh oh!

bgenia commented Nov 18, 2024

Uh oh!

jakebailey commented Jun 30, 2025

Uh oh!

typescript-bot commented Jun 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Jul 1, 2025

Uh oh!

typescript-bot commented Jul 1, 2025

Uh oh!

typescript-bot commented Jul 1, 2025

tsc

Uh oh!

typescript-bot commented Jul 1, 2025

Uh oh!

Andarist commented Jul 1, 2025

Uh oh!

Uh oh!

typescript-bot commented Jun 30, 2025 •

edited

Loading